Update cmssw-queue-override.file #6057
Conversation
remove FWCore packages from patch until we get them to work. add patch corresponding to pr 30628 for testing purposes.
|
A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_11_2_X/rootmodule. @cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks. |
|
Pull request #6057 was updated. |
|
test parameters:
|
|
please test |
|
The tests are being triggered in jenkins.
|
cmssw-queue-override.file
Outdated
| cat CondFormats/RPCObjects/BuildFile > bf | ||
| mv bf CondFormats/RPCObjects/BuildFile | ||
| cat src/CondFormats/RPCObjects/BuildFile > bf | ||
| mv bf src/CondFormats/RPCObjects/BuildFile |
There was a problem hiding this comment.
you are missing .xml extension here. it should be src/CondFormats/RPCObjects/BuildFile.xml.
By the way you need to check if src/CondFormats/RPCObjects/BuildFile.xml exists (note that for patch builds this might be missing). Also such changes are not going to work in dev area e.g. when one addpkg CondFormats/RPCObjects
|
For now we can not test changes for top level package e.g cmssw itself. As PR tests do not build RPM of cmssw, so this change is not going effect PR tests. |
|
Ah - right - I will fix and do a separate test…
I hope never to build a patch release or developer area with this change…
On Jul 10, 2020, at 8:52 AM, Malik Shahzad Muzaffar <[email protected]<mailto:[email protected]>> wrote:
@smuzaffar commented on this pull request.
________________________________
In cmssw-queue-override.file<#6057 (comment)>:
@@ -36,7 +36,7 @@ Source20: CXXModules.mk
echo "<flags LCGDICT_PACKAGE=\\"$p\\"/>" >> config/BuildFile.xml \
done
echo "<use name=\\"CondFormats/L1TObjects\\"/>" > bf
- cat CondFormats/RPCObjects/BuildFile > bf
- mv bf CondFormats/RPCObjects/BuildFile
+ cat src/CondFormats/RPCObjects/BuildFile > bf
+ mv bf src/CondFormats/RPCObjects/BuildFile
you are missing .xml extension here. it should be src/CondFormats/RPCObjects/BuildFile.xml.
By the way you need to check if src/CondFormats/RPCObjects/BuildFile.xml exists (note that for patch builds this might be missing). Also such changes are not going to work in dev area e.g. when one addpkg CondFormats/RPCObjects
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#6057 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ25LEDBIF4IGD5S4PTR223CPANCNFSM4OWJLNPA>.
|
|
by the way, to test such changes, you need to have cmssw PR and test it togather with cmsdist PR |
|
abort |
|
Pull request #6057 was updated. |
|
-1 Tested at: 3107dda CMSSW: CMSSW_11_2_CXXMODULE_X_2020-07-09-2300 I found follow errors while testing this PR Failed tests: Build
I found compilation error when building: >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_CXXMODULE_X_2020-07-09-2300/src/CalibMuon/RPCCalibration/src/RPCFakeCalibration.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_CXXMODULE_X_2020-07-09-2300/src/CalibMuon/RPCCalibration/src/RPCPerformanceESSource.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_CXXMODULE_X_2020-07-09-2300/src/CalibMuon/RPCCalibration/src/SealModule.cc >> Building edm plugin tmp/slc7_amd64_gcc820/src/CalibMuon/RPCCalibration/src/CalibMuonRPCCalibration/libCalibMuonRPCCalibration.so /cvmfs/cms-ib.cern.ch/nweek-02636/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lCondFormatsRPCObjects collect2: error: ld returned 1 exit status gmake: *** [tmp/slc7_amd64_gcc820/src/CalibMuon/RPCCalibration/src/CalibMuonRPCCalibration/libCalibMuonRPCCalibration.so] Error 1 Leaving library rule at CalibMuon/RPCCalibration >> Leaving Package CalibMuon/RPCCalibration >> Package CalibMuon/RPCCalibration built >> Entering Package CondCore/RPCPlugins |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-pending
labels
remove FWCore packages from patch until we get them to work.
add patch corresponding to pr 30628 for testing purposes.